Support GHC 9.0.2 on Windows

andrewthad commented 2 years ago

Not sure what the AppVeyor build failures means:

src\Chronos.hs:862:74: error:
    * Couldn't match type: t0 [a0] -> [a0]
                     with: Language.Haskell.TH.Syntax.Q Language.Haskell.TH.Syntax.Exp
      Expected: Language.Haskell.TH.Lib.Internal.ExpQ
        Actual: t0 [a0] -> [a0]
    * Probable cause: `concat' is applied to too few arguments
      In the expression: concat
      In the untyped splice: $concat
src/Chronos/Locale/English.hs:25: failure in expression `import Chronos (january, august, december, october, caseMonth)'
expected: 
 but got: 
          ^
          <interactive>:1:1: error:
              attempting to use module `main:Chronos' (src\Chronos.hs) which is not loaded
src/Chronos.hs:357: failure in expression `deriving instance Arbitrary Time'
expected: 
 but got: 
          ^
          <interactive>:47:29: error:
              Not in scope: type constructor or class `Time'
Examples: 31  Tried: 9  Errors: 0  Failures: 2

chshersh commented 2 years ago

I'm also not sure what does this mean. chronos builds locally for me on Ubuntu with GHC 9.0.1 and all tests pass as well.

Benchmarks don't build though as thyme doesn't support GHC 9.0 yet:

https://github.com/liyang/thyme/pull/70

chshersh commented 2 years ago

@andrewthad The CI seem to work now after I rebased on the latest master branch 👍🏻 Is it possible to merge the PR and release the new version of chronos with the GHC 9.0 support? 🙏🏻

andrewthad commented 2 years ago

Merged. Also, see https://github.com/andrewthad/chronos/pull/73 where I have a release candidate for 1.1.4 which supports GHC 9.0.2 but not 9.2.1. If that looks good to you, I will merge and release it.

chshersh commented 2 years ago

@andrewthad Yep, this looks perfect 🔝 GHC 9.2 support is not urgent to me so I'm happy with the current release 🤗

byteverse / chronos

Support GHC 9.0.2 on Windows #71