byteverse / contiguous

Typeclass for array types
Other
19 stars 9 forks source link

give internal code a consistent voice #24

Closed chessai closed 5 years ago

chessai commented 5 years ago

some of the code that was ported from primitive brings along with it the problem primitive has, where code is written in a handful of different styles. to me, there are a few noticeable inconsistencies:

  1. sometimes implementing top-level functions using lambdas, vs. not doing that. e.g. (reverseMutable = \arr -> ...)
  2. naming conventions: i prefer arr and marr for arrays and mutable arrays, respectively, but in some places these are named ary/mary.
  3. using guards when looping through an array vs using if-then-else. this is the most in-your-face one. i prefer if-then-else instead of guards.
chessai commented 5 years ago

this is ongoing