search

byteverse / contiguous

Typeclass for array types
Other
19 stars 9 forks source link

build on ghc 9.2 (once primitive-unlifted has also updated) #46

Closed cumber closed 2 years ago

cumber commented 3 years ago

With this change I'm able to build in GHC 9.2.1, 9.0.1, and 8.10.7, provided I'm building against a similarly updated version of primitive-unlifted. I've submitted a request for such an update: https://github.com/haskell-primitive/primitive-unlifted/issues/26

Once there is such a release (say 0.1.3.1), I'm not quite sure whether it's better to have a release of contiguous that uses CPP like this to work across GHC versions, but would then presumably need a weird dependency constraint like base < 4.16 || primitive-unlifted >= 0.1.3.1. Or to just make a non-CPP version that only works on GHC 9.2, and revise the bounds on the previous versions to base < 4.16.

andrewthad commented 3 years ago

I think the most straightforward solution is to unconditionally require primitive-unlifted >= 0.1.3.1 && < 0.2. There's no reason for anyone to want to stay on 0.1.3.0. I'm going ahead and adding base < 4.16 to older releases. Could you update this PR with a patch version bump and also tighten the lower bound on primitive-unlifted?

andrewthad commented 3 years ago

And also add a changelog entry.

cumber commented 2 years ago

How's that?

teto commented 2 years ago

nice. What about a new hackage release ?