byteverse / haskell-ip

IP Address implementation
Other
20 stars 19 forks source link

failure in expression `Chunks.concat #64

Closed teto closed 4 years ago

teto commented 4 years ago

the tests fails on nixos-unstable with ghc 8.6.5. any hint ?

Building test suite 'doctest' for ip-1.7.1..
[1 of 1] Compiling Main             ( test/Doctests.hs, dist/build/doctest/doctest-tmp/Main.o )
Linking dist/build/doctest/doctest ...
running tests
Running 3 test suites...
Test suite test: RUNNING...
Test suite test: PASS
Test suite logged to: dist/test/ip-1.7.1-test.log
Test suite spec: RUNNING...
Test suite spec: PASS
Test suite logged to: dist/test/ip-1.7.1-spec.log
Test suite doctest: RUNNING...
src/Net/IPv4.hs:521: failure in expression `Chunks.concat (UB.run 1 (byteArrayBuilderUtf8 (fromOctets 192 168 2 13)))'
expected: [0x31, 0x39, 0x32, 0x2e, 0x31, 0x36, 0x38, 0x2e, 0x32, 0x2e, 0x31, 0x33]
 but got: [0x31,0x39,0x32,0x2e,0x31,0x36,0x38,0x2e,0x32,0x2e,0x31,0x33]
                ^

Examples: 172  Tried: 172  Errors: 0  Failures: 1
Test suite doctest: FAIL
Test suite logged to: dist/test/ip-1.7.1-doctest.log
2 of 3 test suites (2 of 3 test cases) passed.
note: keeping build directory '/tmp/nix-build-ip-1.7.1.drv-0'
builder for '/nix/store/90mkjkiyf8pld9irp4lkhi7d8kj6q1s2-ip-1.7.1.drv' failed with exit code 1
cannot build derivation '/nix/store/c3cfqlpv2ikm3ws1aw52k75r4v01c2cx-ghc-8.6.5-with-packages.drv
andrewthad commented 4 years ago

This was fixed on master in https://github.com/andrewthad/haskell-ip/commit/3380405540e1270a1027d1ab44a8906db08965c9

It just hasn’t been released to hackage yet since there aren’t any other changes that have happened since then.

teto commented 4 years ago

great, I checked the issues but not the commits. thanks !