search

byteverse / haskell-ip

IP Address implementation
Other
20 stars 19 forks source link

Add Generic for IPv6 #70

Closed adamflott closed 2 years ago

adamflott commented 4 years ago

Needed to derive Serialise from serialise package. Depends on a new wide-word package with https://github.com/erikd/wide-word/pull/51

andrewthad commented 4 years ago

This seems fine. When wide-word is released with the Generic instance, bump its lower bound in this PR and ping me, and then I can merge it.

adamflott commented 3 years ago

@andrewthad wide-word 0.1.1.2 was released with Generic instances. https://hackage.haskell.org/package/wide-word-0.1.1.2/changelog

Also, would you be opposed to getting this library into Stackage? (one of my favorites :)

andrewthad commented 3 years ago

This PR still needs to bump the lower bound on wide-word.

I'd be fine with getting this into stackage, but I'd like to address https://github.com/andrewthad/haskell-ip/issues/69 first since it is a considerable breaking change.

andrewthad commented 3 years ago

Also, needs a changelog entry.

dbalan commented 3 years ago

I need this :) @adamflott @andrewthad would you mind me finishing up this PR?

andrewthad commented 3 years ago

Certainly, if you finish it, I'll merge it.

adamflott commented 2 years ago

@andrewthad updated changelog and lower bounds