search

bytewriter / check-common-ups

autodetect ups brand (APC/CyberPower) and check UPS status for icinga2 with perfdata
1 stars 6 forks source link

Performance data seems to be in wrong format #2

Open KaliszAd opened 5 years ago

KaliszAd commented 5 years ago

The performance data doesn't seem to be in the correct format according to this ticket which is similar in nature.

Here is an example (it appears, one semicolon is missing):

[administrator@szftlmon01 ~]$ '/opt/icinga-plugins-manubulon/check_common_ups.sh' '-C' 'public' '-H' '10.30.1.5' '-I' '250' '-X' '-d' 'C' '-i' '205' '-x'
OK: host: ndrftlusv01: APC Smart-UPS X 3000: OK;| Temp=25;45;50;0 Line_Voltage=224;250;;205 Load=26;70;80;0 RunTime=136;10;8;0
bytewriter commented 5 years ago

Where is the missing semicolon? This looks correct to me, according to: https://icinga.com/docs/icinga1/latest/en/perfdata.html#formatperfdata

'disk usage'=78%;80;90;;; # invalid (trailing semicolon after max value) temperature=23;;;20;30 # valid (rule 6)

KaliszAd commented 5 years ago

Look at the output I provided, there are always 3 semicolons instead of 4. I mean the plugin is still helpful, but the performance data are not digested by my current (as of end of October) Icinga2 installation. It will not get digested by InfluxDB for graphing by Graphana.

bytewriter commented 4 years ago

I see what you mean. I will make a change.