byteyilabs / yi-note

YiNote browser extension - online video note taking tool
https://www.yinote.co
GNU General Public License v3.0
356 stars 50 forks source link

Yinote window doesnt close in Chrome #106

Open gandalf34 opened 2 years ago

gandalf34 commented 2 years ago

Describe the bug

The yinote window open on the right hand side close in firefox but doesnt close in Chrome.

To Reproduce Steps to reproduce the behavior:

  1. Click on extension . Yinote will open
  2. Click on the arrow > at he right hand side of the Search field.
  3. Nothing happens.

Expected behavior It is expected to close by sliding to the right

Screenshots If applicable, add screenshots to help explain your problem.

Browser (please complete the following information): -Version 96.0.4664.45 (Official Build) (64-bit)

Additional context Add any other context about the problem here

https://user-images.githubusercontent.com/86377241/143216583-cb9f1214-0580-4f7d-af34-53f552c9e92d.mp4

.

hawkiboy commented 2 years ago

Agree, this makes for a BAD experience. You can hit the refresh button and that gets rid of it.

Broodlisk commented 2 years ago

I have the same issue

quentin-mckay commented 2 years ago

Same issue for me. I'm on Chrome Version 99.0.4844.74 (Official Build) (64-bit)

rcsoul commented 2 years ago

The same thing happens to me.

chris2052 commented 2 years ago

Same in Brave-Browser

phanirithvij commented 2 years ago

same as #105

No2515 commented 2 years ago

No fix yet?

nikevelik commented 2 years ago

I have the same issue

lemattma commented 2 years ago

@shuowu I've been debugging this issue and it seems to be related to the file packages/extension/src/ui/containers/App/styled.js on the transform property:

export const StyledDrawer = styled.div`
  ...

  transition: transform 0.3s;
  /* it's not updating the value, but props.open does change. Maybe some cache issue? */
  transform: ${props => (props.open ? 'translateX(0)' : 'translateX(100%)')}; 

  ...
`;

I'll keep digging but if you know how to fix it please let me know.

lemattma commented 2 years ago

I've created a PR fixing this issue: https://github.com/shuowu/yi-note/pull/113

hh23485 commented 2 years ago

@shuowu can you help to review this PR and release a new version

I've created a PR fixing this issue: #113

No2515 commented 2 years ago

I would love to help but I'm a total noob

On Sun, Sep 4, 2022 at 11:46 PM hh23485 @.***> wrote:

@shuowu https://github.com/shuowu can you help to review this PR and release a new version

I've created a PR fixing this issue: #113 https://github.com/shuowu/yi-note/pull/113

— Reply to this email directly, view it on GitHub https://github.com/shuowu/yi-note/issues/106#issuecomment-1236513743, or unsubscribe https://github.com/notifications/unsubscribe-auth/AZ5J7GQ7A3LW2T4OKEUDCWDV4VUJXANCNFSM5IVUBRXQ . You are receiving this because you commented.Message ID: @.***>

hh23485 commented 2 years ago

Any updates here?

shoneriki commented 1 year ago

There seems to be numerous PR's to this extension to fix this issue, but this problem is still prevalent way into 2023...

ThDag commented 1 year ago

july 2023 and its still there , didnt got fixed yet??

shoneriki commented 1 year ago

july 2023 and its still there , didnt got fixed yet??

no, the issue hasn't been fixed yet

ThDag commented 1 year ago

i have found a %1000 better tool to take notes on videos thats faster, easier, cleaner

idk if its rude but there is just no way i can use with the bugs and no maintenance

its NattyNote its very not known i found it in some reddit post

you can find it in chrome web store

instead of creating a webpage to store and the notes you took across web, it caches the youtube link so all the notes are in the same place as the video and there is a list of cached files

it stores way less space on the screen after all you need to see when noting a quick sentence is the the text, better then covering the whole side of the screen

Medullitus commented 1 year ago

trash

ThDag commented 1 year ago

why

mbalassane commented 1 year ago

We can use an alternative for closing the left pane of yinote by refreshing your web page. Press Crtl+r to refresh it quickly and it will disappear

shuowu commented 8 months ago

Issue has been fixed in version 1.8.0 in both chrome & edge store (pending store review, it will be available in store soon)!