byteyilabs / yi-note

YiNote browser extension - online video note taking tool
https://www.yinote.co
GNU General Public License v3.0
356 stars 50 forks source link

YiNote bookmarks are mislabeled when bookmarking youtube video from playlist #55

Open enlargedhousecats opened 4 years ago

enlargedhousecats commented 4 years ago

image

When making notes of a video that was arrived to as a part of a playlist, YiNote records only the first video's name, and will only link to the first video when clicking on the bookmark. Note the many Duplicate bookmark titles

image image unique note pages are still generated

image

notes are retained on the correct pages

however, they are practically inaccessible from the bookmarks menu.

Sometimes there is a workaround where you can refresh the page and YiNote can record the bookmark as a new bookmark, but this does not correct notes that were mislabeled and doesn't seem to affect notes that were arrived to in a playlist

shuowu commented 4 years ago

@enlargedhousecats Does the following faqs help? https://github.com/shuowu/yi-note#faqs

shuowu commented 4 years ago

Also, it would make sense to put a reload button in the extension to correct existing bookmarks.

tomasdore commented 4 years ago

I had a similar problem, posted which I thought was a 'bug' until I found that those FAQs solved it. But maybe the problem will repeat for every new person, because YouTube is so popular. So.... is it possible to make this setting on by default? So the setting 'reload page' would be on, and the YouTube page domain would already be added by default. I think this might avoid the "problem" coming back for new people. Because few people will post on GitHub, so the number of confused people must already be more than us two (me and enlargedhousecats)!

shuowu commented 4 years ago

@tomasdore thanks for the suggestion! The idea is I don't want the extension silently change how the hosted page works. In the future , i may try give user some feedback message to aware this issue when user firstly start a youtube video with yinote. Then user can decide to turn the setting on or not.

fkuersch commented 2 years ago

I didn't realized this issue until I got ~30 notes and was unable to find them again. At least showing a big warning on YouTube when this option is disabled, should be implemented.

Isn't there another way of getting the correct metadata for the current video on YouTube? That way, this reload workaround would not be necessary anymore.