search

byteyilabs / yi-note

YiNote browser extension - online video note taking tool
https://www.yinote.co
GNU General Public License v3.0
354 stars 49 forks source link

JSON export also exports deleted video bookmarks/notes #79

Closed 5A9RSG0S6u0HNDkwpRw closed 3 years ago

5A9RSG0S6u0HNDkwpRw commented 3 years ago

Hi,

Thanks very much for your work. Great video extension

I noticed that the JSON export also exports deleted bookmarks.

After exporting I noticed a few duplicates which seems to be either deleted/modified notes.

As temporary solution, do you know if there is a way to identify within the JSON which bookmarks have been deleted or would I need to go back through each video manually and remove them from the JSON?

I noticed the markdown export option for individual videos works correctly and only shows the current set of bookmarks (not the deleted ones). This would be quite difficult to use across a large number of different videos though with only a couple of notes in each

Thanks very much for your time and effort!

5A9RSG0S6u0HNDkwpRw commented 3 years ago

Hi, I haven't been able to reproduce this and have deleted notes then exported JSON files without any problems.

The original scenario had lots of bookmarks and chrome tabs open, I was also using the export and clear/export options a lot from the settings page so maybe that caused some corrupt data at the time.

Both versions of the JSON export file have v1.6.0 so I don't think there have been any updates that could have fixed an issue if there was one in the first place so this can be closed as 'user error' and if I manage to reproduce it in the future I'll open a new one although its working fine at the moment.

Thanks!