search

byu-dml / d3m-dynamic-neural-architecture

1 stars 1 forks source link

Added a rerun command #173

Open erikhuck opened 5 years ago

erikhuck commented 5 years ago

closes #99

codecov-io commented 5 years ago

Codecov Report

Merging #173 into develop will increase coverage by 12.83%. The diff coverage is 90.98%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop    #173       +/-   ##
===========================================
+ Coverage    56.87%   69.7%   +12.83%     
===========================================
  Files           33      35        +2     
  Lines         2219    2446      +227     
===========================================
+ Hits          1262    1705      +443     
+ Misses         957     741      -216
Impacted Files Coverage Δ
test/test_models.py 96.77% <100%> (+3.15%) :arrow_up:
dna/utils.py 87.5% <100%> (+27.5%) :arrow_up:
dna/__main__.py 67.59% <72%> (+29.54%) :arrow_up:
test/utils.py 93.54% <93.54%> (ø)
test/test_main.py 96.36% <96.36%> (ø)
dna/data.py 84.24% <0%> (+10.93%) :arrow_up:
run_tests.py 100% <0%> (+16.66%) :arrow_up:
... and 6 more

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update adb7e01...6cdec25. Read the comment docs.

bjschoenfeld commented 5 years ago

Can you add some tests? A good test would be: run a model; rerun the model using the output run.json; and compare the run output with the rerun output to make sure they are the same (except id, compute time, etc.).

bjschoenfeld commented 5 years ago

The one added test more than doubles the run time of the tests. Can you reduce the runtime? Ideally, the whole test suite would run in just a couple seconds.