search

byu-dml / d3m-primitives

BYU-DML primitives for the DARPA D3M program
MIT License
5 stars 0 forks source link

Default random seed should be random #11

Closed bjschoenfeld closed 6 years ago

bjschoenfeld commented 6 years ago

https://github.com/byu-dml/d3m-primitives/blob/90fd5d06f04052af6f58d84b2c43a9cf8a20b833/byu_dml/imputer/random_sampling_imputer.py#L56

The default random seed should not be fixed. It should be set to None and then randomly generated to be something other than None.

mitar commented 6 years ago

Please not do so. Randomness should be controller by TA2. (And if it is not set to 0 it will fail primitive the validator, anyway.)

bjschoenfeld commented 6 years ago

This issue should have been closed. The default is 0. We ran into the primitive validator.