search

byu-dml / metalearn

BYU's python library of useable tools for metalearning
MIT License
22 stars 6 forks source link

Model based features #136

Closed emrysshevek closed 5 years ago

emrysshevek commented 6 years ago

closes #72

bjschoenfeld commented 6 years ago

I think it would be beneficial for you and the package if you spent a little time figuring out how to get all these metafeatures in one traversal of the tree. It may be helpful to have a more object oriented approach, to store all pertinent information as the tree is traversed.

rlaboulaye commented 5 years ago

@macetheace96 Let's sit down tomorrow to look over this. I have a few questions about it. For example, there seem to be a couple of magic numbers. Also, I'm not sure if it is a good idea to have class methods that would error if not called before other class methods, even if the order is specified in the metafeatures.json file.