search

byu-dml / metalearn

BYU's python library of useable tools for metalearning
MIT License
22 stars 6 forks source link

Remove openml_requirements.txt #179

Open epeters3 opened 5 years ago

epeters3 commented 5 years ago

There is an openml_requirements.txt file which lists all dependencies for the openml package. Since openml and all its dependencies can be installed with just the pip install openml command, should the openml_requirements.txt file be removed, and openml just be added to the requirements.txt file instead?

If removed, the section of the readme which discusses running openml_requirements.txt would also need to be removed.

bjschoenfeld commented 5 years ago

The reason for keeping them separate was to keep the main package and test development separate from this side feature of comparing with openml. I wonder if we should just include the compare with openml in the regular tests and then combine the requirements too.

The requirements file is the output of pip3 freeze. Having all the dependencies specified, not just the direct ones, ensures reproducibility.