search

byu-magicc / magicc_sim

Extra ROSflight simulation plugins and agents used in the lab
1 stars 3 forks source link

Made the gimbal xacro topics match the camera plugin #2

Closed skyler237 closed 6 years ago

skyler237 commented 6 years ago

This helps to make applications using image transport easier

gellings commented 6 years ago

I could be wrong but I thought that the old way was appropriate for using image transport. Maybe I need to be educated at why this is better.

skyler237 commented 6 years ago

I also am not too familiar with image transport, so correct me if I am wrong, but I had problems passing the gimbal plugin data to the visual_frontend node (using image transport) because the gimbal was publishing on the topics /camera/image_raw and /camera/image_raw/camera_info, but image transport seemed to expect the image_raw and camera_info topics to both be under the same namespace (i.e. /camera/image_raw and /camera/camera_info.

jerelbn commented 6 years ago

I'm not sure what the difference between the old and new ways of using image_transport are but having the option to change topic names in plugins is useful I think.

skyler237 commented 6 years ago

I also just changed image_camera_info_topic to camera_info_topic and removed the weird tab