roscopter/src/waypoint_manager/velocity_manager.py retained the import of set_trace
I personally don't have a problem with it, but others might. Some people care that that type of line doesn't ever get included in a commit. The main team should discuss and come to an agreement if this is ok. (My vote is cast.)
Also, in-line comments are discouraged in PEP8, and there are a couple here. Probably, they are everywhere in this massive project. This is one point from PEP8 with which I agree. In general, don't use them, except in certain, limited cases.
Probably once the todo list items David posted on the slack channel are completed, a refactor would be good, to clean up style, consistency, and general code quality.
careful:
roscopter/src/waypoint_manager/velocity_manager.pyretained the import ofset_traceI personally don't have a problem with it, but others might. Some people care that that type of line doesn't ever get included in a commit. The main team should discuss and come to an agreement if this is ok. (My vote is cast.)
Also, in-line comments are discouraged in PEP8, and there are a couple here. Probably, they are everywhere in this massive project. This is one point from PEP8 with which I agree. In general, don't use them, except in certain, limited cases.
Probably once the todo list items David posted on the slack channel are completed, a refactor would be good, to clean up style, consistency, and general code quality.