search

byu-oit / handel

[Archived because BYU moved to Terraform.] Orchestrates your AWS deployments so you don't have to.
Apache License 2.0
14 stars 4 forks source link

Support for "essential" and "ulimit" options in task definition for ECS #294

Open saholman opened 6 years ago

saholman commented 6 years ago

http://docs.aws.amazon.com/AmazonECS/latest/developerguide/task_definition_parameters.html

dsw88 commented 6 years ago

@saholman I purposely didn't put these in ECS because it uses a single service per cluster model currently, so having to set essential and ulimit didn't seem to make sense there. In a shared cluster model (which will be a plugin probably at this point), then these would make more sense.

I might be missing something here though, why do you think these ought to be added to the ECS service?

saholman commented 6 years ago

@dsw88 If I understand correctly, default ulimits are set for the running container and I believe I was hitting that limit so I wanted to be able to change it. I think it is still helpful with a single service.
The essential option is helpful when debugging or enhancing a service because the whole service doesn't cycle when one particular container fails. For example, I was working on a project that had a few worker containers that did different things and I wanted the service to keep running while I worked on trying to fix the one container that implemented a particular feature.
I don't have a use case for either of these anymore, so I don't think there is any rush to get them done.