search

byu-oit / handel

[Archived because BYU moved to Terraform.] Orchestrates your AWS deployments so you don't have to.
Apache License 2.0
14 stars 3 forks source link

Fargate Check Phase returns unhelpful Error #602

Open ndpete opened 5 years ago

ndpete commented 5 years ago

If the containers section is inputed as an object instead of an array the error should be caught (line 130 is probably already doing this) and probably returned before checking the containers section on line 139 Or else an unhelp error message like this is returned: 

$> handel check
info:    Executing Check phase in environment 'dev'
error:   Error occurred during check: Cannot read property 'filter' of undefined

https://github.com/byu-oit/handel/blob/ececbcfd67ef743fc176f55c91e7640d8444e302/handel/src/services/ecs-fargate/index.ts#L130-L141

ndpete commented 5 years ago

Or alternatively the routing Section and Container section should do schema validation in the check call rather than everything at the top level?