search

byu-osl / bookout

A person-to-person library
3 stars 0 forks source link

Cannot remove books with an apostrophe from library #2

Closed n8carrier closed 11 years ago

n8carrier commented 11 years ago

Example: Add Ender's Game to the library and try to remove it. You won't be able to remove it because Javascript doesn't like the apostrophe that gets passed through.

Most likely there are other characters affected, but we haven't looked into it.

trevnet commented 11 years ago

This is now fixed. I am escaping the title before passing it to the front end.

-Trever

On Wed, Apr 3, 2013 at 8:48 PM, Nate Carrier notifications@github.comwrote:

Example: Add Ender's Game to the library and try to remove it. You won't be able to remove it because Javascript doesn't like the apostrophe that gets passed through.

Most likely there are other characters affected, but we haven't looked into it.

— Reply to this email directly or view it on GitHubhttps://github.com/byu-osl/bookout/issues/2 .

n8carrier commented 11 years ago

Natalie reported that she is running into the same problem with titles that have an apostrophe on the search page. Can you make the same fix on the search back end?

trevnet commented 11 years ago

This is now fixed.

On Sat, Apr 13, 2013 at 4:49 PM, Nate Carrier notifications@github.comwrote:

Natalie reported that she is running into the same problem with titles that have an apostrophe on the search page. Can you make the same fix on the search back end?

— Reply to this email directly or view it on GitHubhttps://github.com/byu-osl/bookout/issues/2#issuecomment-16342372 .