byuccl / RapidSmith2

RapidSmith2 - the Vivado successor to RapidSmith. Released Jan 4, 2017.
Other
41 stars 13 forks source link

Default properties are shared between cells #303

Closed trharoldsen closed 6 years ago

trharoldsen commented 6 years ago

Inside PropertyList, when the user requests a property which has not been updated by the user, the PropertyList returns the default property with the specified name (if it exists). The iterator will also yield the default property. The values in the properties are mutable field and can be modified. As default properties are shared by all cells of a given type, updating the value field of these properties affects all cells of this type. This can lead to unexpected bugs.

To prevent this, we should prevent users from updating the value of the default properties. Possible fixes include:

I'm personally in favor of the first option.

trharoldsen commented 6 years ago

Fixed in #314