search

byuccl / RapidSmith2

RapidSmith2 - the Vivado successor to RapidSmith. Released Jan 4, 2017.
Other
41 stars 13 forks source link

Design::deepCopy does not work correctly #304

Open trharoldsen opened 7 years ago

trharoldsen commented 7 years ago

Method was not updated for new structure like pseudopins and macros.

nelsobe commented 6 years ago

Note: be sure to address property copying when it is fixed since that does not work in the fixes of #314.

trharoldsen commented 6 years ago

As @nelsobe mentioned, the deep copy methods may prove troublesome to keep up to date with merges. Though I don't necessarily agree, there seems to be a willingness to add additional parameters to the base cell classes that will be difficult to keep up the deep copy up to date with.

One solution would be to move deep copy out of the primary clases and into its own class turning it into more of a second class object. Or we could completely move it over to the rscad repo and only keep what I need.

trharoldsen commented 6 years ago

What is the status of deep copy? Do we want to maintain it or remove it?