byuccl / RapidSmith2

RapidSmith2 - the Vivado successor to RapidSmith. Released Jan 4, 2017.
Other
41 stars 13 forks source link

Dynamic Pin Mappings contain nc when no connection exists #357

Closed trharoldsen closed 5 years ago

trharoldsen commented 5 years ago

Instead of the xml containing no pin mappings for cells without pin connections, the generated xml containing the pin mappings contains a value "nc". I doubt this is what we want. As the mapping is generated by tincr, maybe it should be posted on that page?


<cells>
  <cell type="RAMB36E1" bel="RAMB36E1" hash="RAMB36E1 RAMB36E1 TDP 36 36 36 36">
    <properties>
      <property key="RAM_MODE" val="TDP" />
      <property key="READ_WIDTH_A" val="36" />
      <property key="READ_WIDTH_B" val="36" />
      <property key="WRITE_WIDTH_A" val="36" />
      <property key="WRITE_WIDTH_B" val="36" />
    </properties>
    <pins>
      ....
      <pin cellPin="WEBWE[4]" belPin="nc" />
    </pins>
  </cell>
  ....
</cells>
nelsobe commented 5 years ago

Good question. And, since this code is used by RS2 users and code, having the discussion here makes sense to me at some level.

The decision to output the "nc" value was an arbitrary decision to ensure that every cellPin had an entry. If there is a reason to not do this but simply eliminate the pin declaration for unmapped pins, that can be easily done.

What are pros and cons?

trharoldsen commented 5 years ago

Pros

Cons

trharoldsen commented 5 years ago

I don't see us ever changing this at this point so I'm closing it.