ninja_mode - Githubissues

byuccl / bfasst

Tools for FPGA Assurance Flows

Apache License 2.0

12 stars 4 forks source link

ninja_mode #467

Closed yonnorc42 closed 2 months ago

yonnorc42 commented 2 months ago

Added the option to run ninja in serial mode Fixes #451

jgoeders commented 2 months ago

Any reason to not directly expose the -j argument? I think it might be nice to give the user control over the number of threads.

yonnorc42 commented 2 months ago

I thought it might be nice to add a level of abstraction for people who didn't know anything about ninja, but I can change it to use -j directly.

jgoeders commented 2 months ago

@yonnorc42 The -j notation is actually fairly universal (it's what regular makefiles use as well), so in this case, I think it's best to follow convention. Thanks for making the change.