search

byuccl / bfasst

Tools for FPGA Assurance Flows
Apache License 2.0
12 stars 5 forks source link

Redundant unittests? #476

Closed reillymck closed 6 months ago

reillymck commented 6 months ago

https://github.com/byuccl/bfasst/blob/main/test/flows/test_vivado_flow.py#L46 https://github.com/byuccl/bfasst/blob/main/test/scripts/test_ninja_flow_manager.py#L95

These two seem to be doing the same thing (and the same for every file in test/flows). Maybe I'm missing something?

reillymck commented 6 months ago

Both files are being ran though. Total overlap between them should be investigated.

yonnorc42 commented 6 months ago

Yeah I think you're right, they seem to do the same thing. But for the same flow, Vivado, why does one of them have the expected number of build statements at 5, and for the other, 6? They're each offset by 1 and I'm confused by why.

reillymck commented 6 months ago

I'm not sure, but as I've been running the unit tests for my pr, it seems that not all of the redundant ones run. It looked like possible hanging code.