byuccl / tincr

A Tcl-based CAD Tool Framework for Xilinx's Vivado Design Suite
GNU General Public License v2.0
39 stars 19 forks source link

write_xdlrc: Add GND primitive def for non-series7 devices #70

Closed DallonTG closed 6 years ago

DallonTG commented 6 years ago

The wrong tcl command was being used to add VCC and GND site types to the site type dict that is used to append primitive definitions to the end of a xdlrc file. Instead of both being added, only VCC was added (VCC was the key and GND was the value in the dict). This ultimately resulted in an incorrect XDLRC file.

This PR changes the code by adding both VCC and GND to the dict that is used to append the primitive definitions.

nelsobe commented 6 years ago

@bradselw Good point. This is the 2nd time we have run across the use of a dict instead of a list of sites in the code and that caused problems. Not sure when they were introduced. Will add as an issue.