search

byucs340ta / Winter2019

2 stars 0 forks source link

Game doesn't end if a player has undiscarded destination cards? #310

Closed machupicchu2014 closed 5 years ago

machupicchu2014 commented 5 years ago

It seems that the end game condition doesn't get activated if a player hasn't yet discarded their destination cards.

zackshorts commented 5 years ago

I don't think you should end the game before that player's turn is over.

machupicchu2014 commented 5 years ago

I agree that you shouldn't be able to, but the way your game was implemented, a user doesn't have to discard their cards before the turn switches to the next player. So then, we hit a point where the game should have probably ended, but since they have yet to discard their cards, it keeps going (and I think players could keep taking turns?) We weren't super sure if that's what was happening (we only saw it once), but maybe it's worth looking at?