search

byuflowlab / Solar.jl

Package Containing Methods related to solar energy collection.
Other
0 stars 0 forks source link

Contents of panelgeometry struct #6

Open taylormcd opened 6 years ago

taylormcd commented 6 years ago

The panelgeometry struct currently defines a single panel. Should we keep this design, or have this struct define the geometry of all panels in a solar capture analysis?

This is basically a choice between using an array of panelgeometry structs or a single panelgeometry struct with arrays of data to represent multiple panels.

juddmehr commented 6 years ago

I would say that depends on which has better performance for highly refined geometries. If they're the same, then it doesn't really matter.

taylormcd commented 6 years ago

There's probably not much of a performance difference. I'm leaning towards using a single panelgeometry struct with arrays of data. Arrays of data are often more useful than arrays of structs of data. At least that's been my experience while developing other packages.

juddmehr commented 6 years ago

Sounds good, let's swap out the Floats for Arrays then.