Complete Rewrite + Finite Vortex Core

byuflowlab / VortexLattice.jl

A Comprehensive Julia implementation of the Vortex Lattice Method

MIT License

48 stars 11 forks source link

Complete Rewrite + Finite Vortex Core #8

Closed taylormcd closed 3 years ago

andrewning commented 3 years ago

Amazing work!

Everything looks great. Code is very readable with lots of nice touches. Just some minor comments.

TagBot just changed procedures so you'll need to slightly update that yml file: https://discourse.julialang.org/t/ann-required-updates-to-tagbot-yml/49249
let's brainstorm some names
looks like you changed back to symbolically computing the stability derivatives. Just curious on your thoughts there.

taylormcd commented 3 years ago

Originally I did the symbolically computed derivatives because it was easier when trying to figure out differences between AVL and this package. Main benefits is that they are faster and less memory intensive.