search

byuitechops / action-series-master

The master module for all of the action-series child modules.
3 stars 0 forks source link

fatal bug in universal fix dropbox links #13

Closed danverde closed 6 years ago

danverde commented 6 years ago 
C:\Users\Danverde\Documents\CONVERSION\d2l-to-canvas-conversion-tool\node_modules\action-series-master\actions\universal-fix-dropbox-links.js:163
                if ($(link).attr('href').indexOf('drop_box') != -1) {
                                        ^

TypeError: Cannot read property 'indexOf' of undefined
    at Node.$.each (C:\Users\Danverde\Documents\CONVERSION\d2l-to-canvas-conversion-tool\node_modules\action-series-master\actions\universal-fix-dropbox-links.js:163:41)
    at initialize.exports.each (C:\Users\Danverde\Documents\CONVERSION\d2l-to-canvas-conversion-tool\node_modules\cheerio\lib\api\traversing.js:300:24)
    at parseItem (C:\Users\Danverde\Documents\CONVERSION\d2l-to-canvas-conversion-tool\node_modules\action-series-master\actions\universal-fix-dropbox-links.js:162:22)
    at checkArrays (C:\Users\Danverde\Documents\CONVERSION\d2l-to-canvas-conversion-tool\node_modules\action-series-master\actions\universal-fix-dropbox-links.js:37:13)
    at asyncLib.waterfall (C:\Users\Danverde\Documents\CONVERSION\d2l-to-canvas-conversion-tool\node_modules\action-series-master\actions\universal-fix-dropbox-links.js:66:13)
    at C:\Users\Danverde\Documents\CONVERSION\d2l-to-canvas-conversion-tool\node_modules\async\dist\async.js:473:16
    at next (C:\Users\Danverde\Documents\CONVERSION\d2l-to-canvas-conversion-tool\node_modules\async\dist\async.js:5315:29)
    at C:\Users\Danverde\Documents\CONVERSION\d2l-to-canvas-conversion-tool\node_modules\async\dist\async.js:958:16
    at constructCanvasAssignments (C:\Users\Danverde\Documents\CONVERSION\d2l-to-canvas-conversion-tool\node_modules\action-series-master\actions\universal-fix-dropbox-links.js:111:17)
    at canvas.get (C:\Users\Danverde\Documents\CONVERSION\d2l-to-canvas-conversion-tool\node_modules\action-series-master\actions\universal-fix-dropbox-links.js:138:13)

Error occurred in pathway course 22480 (GS 120)

csammcgrath commented 6 years ago

@danverde, can you please try this again? It should work!

danverde commented 6 years ago

Now it's breaking elsewhere

var arr = $(links).filter((i, link) => $(link).attr('href').includes('drop_box'));
                                                                       ^

TypeError: Cannot read property 'includes' of undefined
    at Node.$.filter (C:\Users\Danverde\Documents\CONVERSION\d2l-to-canvas-conversion-tool\node_modules\action-series-master\actions\universal-fix-dropbox-links.js:175:72)
    at testFn (C:\Users\Danverde\Documents\CONVERSION\d2l-to-canvas-conversion-tool\node_modules\cheerio\lib\api\traversing.js:320:22)
    at C:\Users\Danverde\Documents\CONVERSION\d2l-to-canvas-conversion-tool\node_modules\lodash\_baseFilter.js:14:9
    at C:\Users\Danverde\Documents\CONVERSION\d2l-to-canvas-conversion-tool\node_modules\lodash\_createBaseEach.js:24:11
    at baseFilter (C:\Users\Danverde\Documents\CONVERSION\d2l-to-canvas-conversion-tool\node_modules\lodash\_baseFilter.js:13:3)
    at filter (C:\Users\Danverde\Documents\CONVERSION\d2l-to-canvas-conversion-tool\node_modules\lodash\filter.js:45:10)
    at initialize.filter (C:\Users\Danverde\Documents\CONVERSION\d2l-to-canvas-conversion-tool\node_modules\cheerio\lib\api\traversing.js:330:28)
    at parseItem (C:\Users\Danverde\Documents\CONVERSION\d2l-to-canvas-conversion-tool\node_modules\action-series-master\actions\universal-fix-dropbox-links.js:175:32)
    at checkArrays (C:\Users\Danverde\Documents\CONVERSION\d2l-to-canvas-conversion-tool\node_modules\action-series-master\actions\universal-fix-dropbox-links.js:50:13)
    at asyncLib.waterfall (C:\Users\Danverde\Documents\CONVERSION\d2l-to-canvas-conversion-tool\node_modules\action-series-master\actions\universal-fix-dropbox-links.js:79:13)
zachintosh commented 6 years ago

I've fixed this issue. It just needed a truthy check alongside the includes.