Potential scoping issue

byuitechops / action-series-master

The master module for all of the action-series child modules.

3 stars 0 forks source link

Potential scoping issue #37

Closed zachintosh closed 6 years ago

zachintosh commented 6 years ago

https://github.com/byuitechops/action-series-master/blob/6242a2ffc0f996c03860c1fecf92d3674e47ac5e/actions/universal-fix-dropbox-links.js#L295-L306

You may want to change the "item" parameter to a different name, since the module.exports function brings in an "item" as well. Since the highlighted code above is in the scope of the module.exports function, this could cause scoping issues.

csammcgrath commented 6 years ago

Fixed with the latest pull request.