search

byuitechops / action-series-master

The master module for all of the action-series child modules.
3 stars 0 forks source link

another fatal bug in universal-description-quicklinks #47

Closed danverde closed 6 years ago

danverde commented 6 years ago

It happened in CIT 240 (D2L OU: 61928)

C:\Users\Danverde\Documents\CONVERSION\d2l-to-canvas-conversion-tool\node_modules\action-series-master\actions\universal-description-quicklinks.js:179
            return page.html_url;
                        ^

TypeError: Cannot read property 'html_url' of undefined
    at getCanvasUrl (C:\Users\Danverde\Documents\CONVERSION\d2l-to-canvas-conversion-tool\node_modules\action-series-master\actions\universal-description-quicklinks.js:179:25)
    at pageProperties.forEach (C:\Users\Danverde\Documents\CONVERSION\d2l-to-canvas-conversion-tool\node_modules\action-series-master\actions\universal-description-quicklinks.js:200:26)
    at Array.forEach (<anonymous>)
    at getCorrectLinks (C:\Users\Danverde\Documents\CONVERSION\d2l-to-canvas-conversion-tool\node_modules\action-series-master\actions\universal-description-quicklinks.js:199:24)
    at checkPages (C:\Users\Danverde\Documents\CONVERSION\d2l-to-canvas-conversion-tool\node_modules\action-series-master\actions\universal-description-quicklinks.js:123:17)
    at checkArrays (C:\Users\Danverde\Documents\CONVERSION\d2l-to-canvas-conversion-tool\node_modules\action-series-master\actions\universal-description-quicklinks.js:39:13)
    at checkArrays (C:\Users\Danverde\Documents\CONVERSION\d2l-to-canvas-conversion-tool\node_modules\action-series-master\actions\universal-description-quicklinks.js:71:13)
    at beginProcess (C:\Users\Danverde\Documents\CONVERSION\d2l-to-canvas-conversion-tool\node_modules\action-series-master\actions\universal-description-quicklinks.js:33:9)
    at module.exports (C:\Users\Danverde\Documents\CONVERSION\d2l-to-canvas-conversion-tool\node_modules\action-series-master\actions\universal-description-quicklinks.js:22:9)
sethchilders92 commented 6 years ago

Just merged with Sam's branch that hopefully fixed this. Let me know if it is still broken. @danverde

zachintosh commented 6 years ago

Seems fixed.