search

byulparan / cl-collider

A SuperCollider client for CommonLisp
Other
218 stars 23 forks source link

implement sc's Group.freeAll #129

Closed einsiedlerspiel closed 10 months ago

einsiedlerspiel commented 10 months ago

Implement group-free-all as a function that frees all nodes in a group without freeing that group.

Rename the existing group-free-all to free-all, to better reflect what it does and allow for consistency with sc.

If the latter is too much of a breaking change, I'd be happy to reverse it and give the new function another name. Maybe free-in-group?

byulparan commented 10 months ago

I very much agree with your request. I think it's right cl-collider's APIs to be compatible with sclang (if they don't break CommonLisp's conventions too much). There are many mistakes left over from the early days when I was the only one using it, and I plan to accept corrections for these even if it is late. I'll see if there are any other issues and merge them as soon as possible. Thank you.

byulparan commented 10 months ago

I think server-free-all is better than free-all as a new name.

einsiedlerspiel commented 10 months ago

Yes i think either server-free-all or something like free-all-nodes would be better. Esp. because it doesn't free busses.

Should i change it to server-free-all or do you want to do it yourself?

byulparan commented 10 months ago

plz change it to server-free-all. thanks! :-)