Spacing/indentation cleanup. Removed double spaces in the code, fixed indentation in a few places, and removed trailing spaces at the end of some lines.
Add a .dir-locals.el file with Emacs settings to match the project's indentation style: indent-tabs-mode t and tab-width 8.
Remove use of deprecated get-synthdef-metadata and set-synthdef-metadata functions and officially deprecate them with uiop:with-deprecation to produce style-warnings on use.
Swap out convert-code-table function for *synthdef-function-table* alist, to allow easier user customization if desired. The synthdef-equivalent-function function can be used to get the synthdef equivalent of a function, or it can be set with (setf (synthdef-equivalent-function ...) ...).
Minor fix for the LADSPA ugen, to prevent scsynth from crashing when used with LADSPAs with multiple inputs/outputs like TAP Chorus Flanger (LADSPA ID 2159). I'm not 100% sure about this one but it seems to fix the problem for me and other LADSPAs continue to work as expected.
Sorry for putting all of these in the same PR; if you disagree with any of these changes, I can make a new PR without them, if desired.
byulparan
commented
3 years ago
This PR has several changes:
.dir-locals.elfile with Emacs settings to match the project's indentation style:indent-tabs-mode tandtab-width 8.get-synthdef-metadataandset-synthdef-metadatafunctions and officially deprecate them withuiop:with-deprecationto produce style-warnings on use.convert-code-tablefunction for*synthdef-function-table*alist, to allow easier user customization if desired. Thesynthdef-equivalent-functionfunction can be used to get the synthdef equivalent of a function, or it can be set with(setf (synthdef-equivalent-function ...) ...).Sorry for putting all of these in the same PR; if you disagree with any of these changes, I can make a new PR without them, if desired.