search

bywatersolutions / koha-sandboxes-docker

A Koha sandbox system that only requires Docker to be installed on the sandbox host server.
6 stars 3 forks source link

Signed-off-by lines not using info from the signeff form #48

Open joubu opened 3 years ago

joubu commented 3 years ago

The Signed-off-by lines are creating using the name of the creator of the sandbox, not the name/email fill in on the signoff form.

https://github.com/bywatersolutions/koha-sandboxes-docker/blob/master/sandbox_manager/lib/SandboxManager/Controller/Sandboxes.pm#L157

The following 4 variables are not used:

    my $user   = $self->param('user');
    my $email  = $self->param('email');
    my $bug    = $self->param('bug');
    my $number = $self->param('number');

However, this is set in the config file when the creation form is submitted (sub create_submit):

                GIT_USER_EMAIL    => $email,
                GIT_USER_NAME     => $user,