search

byxb / Whack

Whack Game Starling Project for Flash Player 11
http://www.whacksite.com
120 stars 48 forks source link

Updated Whack! for Starling 1.1 #2

Open PrimaryFeather opened 12 years ago

PrimaryFeather commented 12 years ago

Hi Justin,

I'm Daniel, the main developer of Starling. First of all I must thank you for the amazing work you have done with Whack! You did a great job, especially considering you worked with such an early version of Starling. =)

Since I had to make quite a few changes to Starling since the original release, especially for performance optimizations, Whack does not compile with the latest Starling version at the moment.

Thus, I took the liberty of updating it for the latest version, Starling 1.1 (which will be released within the next days). This pull request contains that update. Furthermore, I removed the Starling code from the project, so that people can reference Starling directly (the latest versions contain swc files for that). If you'd like to have that differently, you can do so, of course. I just committed the source just as I used it on my system.

It would be great if you could accept this pull request! Then people could look at the Whack code in combination with the latest Starling version.

Thanks in advance!

Daniel

byxb commented 12 years ago

Hi Daniel,

Oh, wow, thanks for the work! Let me take a look at it. I've finally been working on the game again and had finished the update to the new framework last week (just hadn't checked it in to github). Let me take a look at your work, I'm actually really interested to see where we've done different things and learn from what you've done!

Sorry for the downtime on the game. I had to shut my company down in December and took a couple month sulk. ;) Now that I'm over that, I'm back on to my projects.

Justin

-----Original Message----- From: Daniel Sperl [mailto:reply@reply.github.com] Sent: Tuesday, May 01, 2012 12:08 PM To: byxb Subject: [Whack] Updated Whack! for Starling 1.1 (#2)

Hi Justin,

I'm Daniel, the main developer of Starling. First of all I must thank you for the amazing work you have done with Whack! You did a great job, especially considering you worked with such an early version of Starling. =)

Since I had to make quite a few changes to Starling since the original release, especially for performance optimizations, Whack does not compile with the latest Starling version at the moment.

Thus, I took the liberty of updating it for the latest version, Starling 1.1 (which will be released within the next days). This pull request contains that update. Furthermore, I removed the Starling code from the project, so that people can reference Starling directly (the latest versions contain swc files for that). If you'd like to have that differently, you can do so, of course. I just committed the source just as I used it on my system.

It would be great if you could accept this pull request! Then people could look at the Whack code in combination with the latest Starling version.

Thanks in advance!

Daniel

You can merge this Pull Request by running:

git pull https://github.com/PrimaryFeather/Whack master

Or you can view, comment on it, or merge it online at:

https://github.com/byxb/Whack/pull/2

-- Commit Summary --

-- File Changes --

M .actionScriptProperties (20) A .gitignore (6) M .project (1) M README (12) D html-template/history/history.css (6) D html-template/history/history.js (678) D html-template/history/historyFrame.html (29) D html-template/index.template.html (111) D html-template/playerProductInstall.swf (0) D html-template/swfobject.js (777) M src/Game.as (28) M src/Whack.as (11) M src/com/byxb/extensions/starling/display/DrawImage.as (191) M src/com/byxb/extensions/starling/display/LargeImage.as (54) M src/com/byxb/extensions/starling/display/ParallaxSprite.as (2) D src/com/byxb/extensions/starling/extensions/ParticleDesignerPS2.as (319) D src/net/hires/debug/Stats.as (181) D src/starling/animation/DelayedCall.as (53) D src/starling/animation/IAnimatable.as (18) D src/starling/animation/Juggler.as (92) D src/starling/animation/Transitions.as (217) D src/starling/animation/Tween.as (153) D src/starling/core/RenderSupport.as (135) D src/starling/core/Starling.as (412) D src/starling/display/Button.as (206) D src/starling/display/DisplayObject.as (324) D src/starling/display/DisplayObjectContainer.as (257) D src/starling/display/Image.as (200) D src/starling/display/MovieClip.as (237) D src/starling/display/Quad.as (192) D src/starling/display/QuadGroup.as (211) D src/starling/display/Sprite.as (57) D src/starling/display/Stage.as (103) D src/starling/errors/AbstractClassError.as (20) D src/starling/errors/AbstractMethodError.as (20) D src/starling/errors/MissingContextError.as (20) D src/starling/errors/ObjectDisposedError.as (20) D src/starling/events/EnterFrameEvent.as (27) D src/starling/events/Event.as (76) D src/starling/events/EventDispatcher.as (108) D src/starling/events/KeyboardEvent.as (47) D src/starling/events/ResizeEvent.as (30) D src/starling/events/Touch.as (89) D src/starling/events/TouchEvent.as (68) D src/starling/events/TouchMarker.as (78) D src/starling/events/TouchPhase.as (25) D src/starling/events/TouchProcessor.as (256) A src/starling/extensions/ColorArgb.as (43) A src/starling/extensions/PDParticle.as (32) R src/starling/extensions/PDParticleSystem.as (196) M src/starling/extensions/ParticleSystem.as (180) D src/starling/text/BitmapChar.as (63) D src/starling/text/BitmapFont.as (251) D src/starling/text/TextField.as (407) D src/starling/textures/ConcreteTexture.as (45) D src/starling/textures/RenderTexture.as (158) D src/starling/textures/SubTexture.as (80) D src/starling/textures/Texture.as (179) D src/starling/textures/TextureAtlas.as (101) D src/starling/textures/TextureSmoothing.as (28) D src/starling/utils/Color.as (51) D src/starling/utils/HAlign.as (28) D src/starling/utils/VAlign.as (28) D src/starling/utils/VertexData.as (195) D src/starling/utils/deg2rad.as (17) D src/starling/utils/formatString.as (22) D src/starling/utils/getNextPowerOfTwo.as (19) D src/starling/utils/rad2deg.as (17) M src/world/Tunnel.as (4) M src/world/World.as (7) M src/world/effects/Dirt.as (6) M src/world/effects/Pow.as (2) M src/world/hammers/FirstSwing.as (1) M src/world/hammers/FullScreenButton.as (6)

-- Patch Links --

https://github.com/byxb/Whack/pull/2.patch https://github.com/byxb/Whack/pull/2.diff

Reply to this email directly or view it on GitHub: https://github.com/byxb/Whack/pull/2

!DSPAM:415,4fa03488644381145813851!

PrimaryFeather commented 12 years ago

Wow, thanks for that FAST response! Great to hear that you've been working on the game yourself -- in that case, you can safely close the pull request, of course.

I know that updating the code was more work than one would expect, especially the "DrawImage" part; sorry for that! This is the part of Starling that was seriously changed, and there's currently no easy way to re-use the AGAL code from another class. Thus, I added the rendering code directly there.

Your code in "LargeImage" motivated me to make a small change to the Quad and Image classes; the way the vertex data is manipulated is now cleaner, and thus easier for subclasses to change. Thanks for pointing me at that issue! ;-)

BTW, the way you created that tunnel is brilliant -- I wouldn't have thought of that! Definitely something I will reuse some time in the future. ;-)

I'm sorry to hear you had to shut down your company! Good luck with whatever you're now up to!!!

Daniel

byxb commented 12 years ago

ok, I responded quickly once, and then a month goes by. ;) I just pushed some changes that make the game work with 1.1 just now.

I've been running into an issue BTW, that I'm hoping that you may have heard of before I go tearing through a lot of code. On my macbook I'm getting a lot of tearing that does not show up on my PC. I've tested on several different macs and gotten similar results on different Flash Players. I'm guessing its a player issue, but since it only seems to happen on the background during the game, something specific that I'm doing seems to be invoking the bug.

My first area of investigation is going to be the texture mapping for the background elements. Since they are infinitely looping I'm wondering if really high UV coordinates might be having some issue. I never bothered to modulo then back to more normal values. After that I'd look at the number of overlapping textures. The tearing seems worse near the ground/sky border, and that is where things are the most densely packed.

Anyways, if you have an ideas, I'd love to hear them, otherwise I'll let you know if I find anything.

PrimaryFeather commented 12 years ago

Hi Justin!

Cool, thanks a lot for pushing your updates! I'll tweet that to our users right away! =) And don't worry, since you had the old Starling code directly in your project, users still could compile and play around with it; and those who asked in the forum, I forwarded to my fork in the meantime. That said, it's great to have an officially working version again! =)

As for your issues, are you talking about a missing vsync, or something else? If it's the vsync, I've seen that myself in some games/players, but I haven't found a way around it yet, either. I think it has to do something with the Flash player, I can't control that with Stage3D. ... or are you talking about something else?

BTW, I just tried to compile the project, but I think you forgot to check in a few files. The compiler complains about a missing "AchievementItem" and an "UpgradeItem", as well as a few graphics.

(I'll wait with the tweet until those are submitted!)

Best regards, Daniel

byxb commented 12 years ago

Thanks Daniel. I'll take a look first thing in the morning and send you an email when it is updated.

Justin

Sent from my phone. Please pardon brevity/errors.

On Jun 4, 2012, at 11:54 PM, Daniel Sperl reply@reply.github.com wrote:

Hi Justin!

Cool, thanks a lot for pushing your updates! I'll tweet that to our users right away! =) And don't worry, since you had the old Starling code directly in your project, users still could compile and play around with it; and those who asked in the forum, I forwarded to my fork in the meantime. That said, it's great to have an officially working version again! =)

As for your issues, are you talking about a missing vsync, or something else? If it's the vsync, I've seen that myself in some games/players, but I haven't found a way around it yet, either. I think it has to do something with the Flash player, I can't control that with Stage3D. ... or are you talking about something else?

BTW, I just tried to compile the project, but I think you forgot to check in a few files. The compiler complains about a missing "AchievementItem" and an "UpgradeItem", as well as a few graphics.

(I'll wait with the tweet until those are submitted!)

Best regards, Daniel

Reply to this email directly or view it on GitHub: https://github.com/byxb/Whack/pull/2#issuecomment-6118703

!DSPAM:415,4fcdad4797008895216237!

PrimaryFeather commented 12 years ago

Thanks!! Have a good night, then! =)

byxb commented 12 years ago

Hi Daniel,

I've updated the repo and it is building for me, but can you just verify?

Justin

-----Original Message----- From: Daniel Sperl [mailto:reply@reply.github.com] Sent: Tuesday, June 05, 2012 12:30 AM To: byxb Subject: Re: [Whack] Updated Whack! for Starling 1.1 (#2)

Thanks!! Have a good night, then! =)

Reply to this email directly or view it on GitHub: https://github.com/byxb/Whack/pull/2#issuecomment-6119561

!DSPAM:415,4fcdb57697001800161800!

PrimaryFeather commented 12 years ago

Hi Justin,

the old Starling version is now removed, but it still doesn't find "data.AchievementItem" and "store.UpgradeItem"! Furthermore, it's looking for the storeAtlas xml/png files. It's also complaining that it doesn't find "VertexImage", but that might also be a consecutive fault.

Daniel

byxb commented 12 years ago

Hi Daniel,

So it turns out I have some learning to do on using Git. ;) It had updated the existing files but not added the new files. Now that I know how to take care of that, it seems to be working. I checked out the project on a clean machine and it is building for me. If you wouldn't mind doing one more verification for me, that would be awesome.

Justin

Justin Church Byxb Interactive http://www.byxb.com +1-415-944-0009

On Jun 5, 2012, at 11:58 AM, Daniel Sperl wrote:

Hi Justin,

the old Starling version is now removed, but it still doesn't find "data.AchievementItem" and "store.UpgradeItem"! Furthermore, it's looking for the storeAtlas xml/png files. It's also complaining that it doesn't find "VertexImage", but that might also be a consecutive fault.

Daniel

Reply to this email directly or view it on GitHub: https://github.com/byxb/Whack/pull/2#issuecomment-6133406

!DSPAM:415,4fce56df97002007615729!

PrimaryFeather commented 12 years ago

Hehe, I've started with Git also about one year ago, so I can perfectly understand g. I don't know how often I forgot to check something in! My favorite mistake, though, is to commit something, but not push it! ;-)

So, I checked the game and now it works perfectly fine with Starling 1.1! Thanks a lot!!! Very cool idea with the new summary screen! =)

Daniel