byzhang / signal-collect

Automatically exported from code.google.com/p/signal-collect
0 stars 0 forks source link

forVertexWithId operation is slow #45

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
The forVertexWithId implementation on WorkerApi is slow, because before doing 
anything it waits for the computation to idle. This is problematic for two 
reasons:
1. It's slow, because there's always a timeout before the coordinator is 
informed about idle states
2. Some continuous dataflow computations might not idle for a very long time

The reason for adding this wait was that there might be pending graph 
modifications that get executed asynchronously and result in unexpected 
behavior. Because we expect the MessageBus to deliver messages in-order and 
because the worker queue is ordered too, this might not actually be a problem. 
If unexpected bahavior this is not a problem in practice or if the issues can 
be dealt with in another way, then we should remove this wait.

Original issue reported on code.google.com by philip.stutz on 2 Nov 2011 at 9:23

GoogleCodeExporter commented 9 years ago
This issue was closed by revision r715.

Original comment by philip.stutz on 8 Nov 2011 at 4:35