search

bzhanglab / WebGestaltR

R package for WebGestalt
https://bzhanglab.github.io/WebGestaltR/
34 stars 14 forks source link

cache file at local #2

Closed shengqh closed 5 years ago

shengqh commented 5 years ago

Dear Dr. Zhang:

I modified the code to save the file to local once it is achieved from website. We perform WebGestaltR a lot at both routine RNAseq and single cell RNAseq analysis. Cache file locally will save us a lot of time. Please consider to merge this feature and ignore the change in DESCRIPTION and README.md. Thank you so much.

Best regards,

Quanhu Sheng

yxngl commented 5 years ago

Thanks for your contribution. We do have similar need in a related project where batches are run and data are read from local files. I will definitely add this as an option.

It would be best if you submitted a PR to the dev branch from one of your branch that allows edits. It needs some minor modification and cleanup, but it is OK and I think I will incorporate the changes in dev branch by myself soon. I will try to add cache for ID mapping later as well.

Do you need cacheURL to be exported?

shengqh commented 5 years ago

Hi, Yuxing:

I exported cacheURL just for test outside of project. You can remove it from export list. Sorry that I don't know how to "submitted a PR to the dev branch from one of your branch that allows edits".

Best,

Tiger

On Mon, May 6, 2019 at 12:53 PM Yuxing Liao notifications@github.com wrote:

Thanks for your contribution. We do have similar need in a related project where batches are run and data are read from local files. I will definitely add this as an option.

It would be best if you submitted a PR to the dev branch from one of your branch that allows edits. It needs some minor modification, but it is OK and I think I will incorporate the changes in dev branch by myself soon. I will try to add cache for ID mapping later as well.

Do you need cacheURL to be exported?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/bzhanglab/WebGestaltR/pull/2#issuecomment-489712768, or mute the thread https://github.com/notifications/unsubscribe-auth/AAVCANIH4LGMFD4AAFOOUV3PUBWBDANCNFSM4HKUPHFQ .