search

bzkf / obds-to-fhir

This project contains a Kafka Stream processor that creates FHIR resources from oBDS-XML data and writes them to a FHIR Topic.
GNU General Public License v3.0
3 stars 1 forks source link

Refactor: Extract method to generate ID usable for all mappers #88

Closed pcvolkmer closed 1 month ago

pcvolkmer commented 2 months ago

Since every mapper uses own implementation to generate the (patient) FHIR ID, this should be done once and usable for all mappers.

pcvolkmer commented 2 months ago

Every mapper uses, example for ObdsConditionMapper:

https://github.com/bzkf/obds-to-fhir/blob/32cd649ca82e5c9ac45ffbed821f0ebc58d64e71/src/main/java/org/miracum/streams/ume/obdstofhir/mapper/ObdsConditionMapper.java#L78-L82

This could be provided by ObdsToFhirMapper.

pcvolkmer commented 2 months ago

Related to #86

The check can be done in one place, not everywere in the mapper classes.

miracum-bot commented 1 month ago

:tada: This issue has been resolved in version 2.2.1 :tada:

The release is available on GitHub release

Your semantic-release bot :package::rocket: