c-bata / kube-prompt

An interactive kubernetes client featuring auto-complete.
MIT License
1.79k stars 134 forks source link

Upgrade dependencies: go-client v8.0.0, k8s v1.11 #26

Closed jwkohnen closed 6 years ago

jwkohnen commented 6 years ago

This is not well tested, but I did the annoying work to upgrade the kubernetes go-client dependency to version 8.0.0 and adjust to the breaking changes that comes with it (mostly breaking changes that were introduced by version 5.0.0). Also I upgraded the kubernetes object's apiVersion where applicable.

I did not test it thouroughly. There seem to be bugs, but since I started using kube-prompt just today, I don't even know yet, if these bugs are related to the upgrade. But I suppose this PR is still worthwhile to move towards an up to date kubernetes client.

jwkohnen commented 6 years ago

Would fix #17.

c-bata commented 6 years ago

Nice! I'll check later.

jwkohnen commented 6 years ago

I've pushed a commit that imports the GCP auth helper. I think it was not necessary to do that before, but it seems my dep upgrade broke authentication to GKE clusters. It may be necessary to include other auth helpers.

c-bata commented 6 years ago

This changes works fine with the kubernetes cluster which is used in our company 👍 Thanks.