search

c-cube / printbox

print nested boxes, lists, arrays, tables in several formats
https://c-cube.github.io/printbox/
BSD 2-Clause "Simplified" License
75 stars 9 forks source link

Split Printbox in three packages to make it easier to install exactly what we want #16

Closed mattiasdrp closed 3 years ago

mattiasdrp commented 3 years ago

dune is bad at looking at optional dependencies in opam and this looks like a "bad" feature in opam (at least it makes it hard to know what needs to be installed or not)

I refactored your repository to allow you to create three distinct packages thus allowing a finer control over what needs to be installed or not.

Notice that I tried to make it the smoothier I could so that anyone using one of the packages and previously already using them just has to put open Printbox (or open Printbox_unicode or open Printbox_html) and won't have nothing else to do.

This should be a better fix for #14

c-cube commented 3 years ago

I agree that subpackages make sense, thank you. Could you revert the part where you move the html directory? There's no need to printbox- prefix the things :)

mattiasdrp commented 3 years ago

I pushed a cleaner version ;-)

c-cube commented 3 years ago

Perfect, thank you!

c-cube commented 3 years ago

I'd take another PR for the tyxml part, if you have time :)

mattiasdrp commented 3 years ago

The same thing as with unicode but for html?

c-cube commented 3 years ago

Yes exactly