Closed vphantom closed 1 year ago
Ok so, why is the address optional in Request.t
? :)
Ok so, why is the address optional in
Request.t
? :)
Because Internal_
does not use an address.
But internal is just for testing purpose, it could take a dummy address (e.g. loopback)
I haven't found anyone actually using it so I didn't dare touch it. Is it related to that (*$R
comment? Is that comment actually test code?
If so, then do I hard-code localhost in that comment or in Internal_
itself? Author's choice. 😉
Option gone, localhost hard-coded in the test case. How's it look now?
merged manually.
It was as difficult as predicted, and I'm pretty sure you won't like it as-is, but this does preserve the client address, when available, down to
Request.t
.