search

c-eg / themoviedbapi

A Java wrapper around the JSON API provided by TheMovieDB.org
https://www.themoviedb.org/
Other
276 stars 94 forks source link

Translation and ProductionCompany models are missing data #108

Closed trestianp closed 2 years ago

trestianp commented 5 years ago

Translation model used for Movie doesn't match the TMDB API documentation : https://developers.themoviedb.org/3/movies/get-movie-translations

It's missing data information : https://github.com/holgerbrandl/themoviedbapi/blob/master/src/main/java/info/movito/themoviedbapi/model/Translation.java

Also, ProductionCompany is missing originCountry.

holgerbrandl commented 5 years ago

Indeed this was added meanwhile and is not part of this java API yet. Would you be willing to contribute a PR to add it?

trestianp commented 5 years ago

Yes, I will create a PR for this.

Bluexin commented 2 years ago

If the ObjectMapper were at least configurable we could tell it to not fail on unknown properties (which is way saner for this kind of library anyway, so it doesn't break when something new is added).

Bluexin commented 2 years ago

I will create PRs to add the missing fields as well as #117

holgerbrandl commented 2 years ago

Thanks, I'm closing this ticket in favor of the PRs

Bluexin commented 2 years ago

Please note that technically this one isn't fixed yet, it just doesn't crash anymore but the new fields haven't been added yet :)