search

c-frame / aframe-extras

Add-ons and helpers for A-Frame VR.
https://c-frame.github.io/aframe-extras/examples/
MIT License
972 stars 305 forks source link

Update a-ocean to use buffer geometry #372

Closed Chabloz closed 2 years ago

Chabloz commented 2 years ago

This will make the a-ocean primitive and ocean component to work in A-Frame >= 1.2

Chabloz commented 2 years ago

Ho i saw this : https://github.com/n5ro/aframe-extras/pull/356 That revert the change following "i3games suggestions " where can i find info about that ? Why the revert ? Do we need to update https://aframe.io/docs/1.3.0/introduction/html-and-primitives.html to mention the problem on a-ocean ?

Chabloz commented 2 years ago

Ok i found the discussion here: https://github.com/n5ro/aframe-extras/issues/348

But i didn't know if i understand it correctly: The revert was because you want a total compatibilty of all the components of aframe-extra with A-Frame >= 1.2 before mergin into master ? And you need help to upgrade the others components ? I'll try to look at the nav-mesh part if i have some spare time.

Thx you for your work on aframe-extras.