c-frame / aframe-extras

Add-ons and helpers for A-Frame VR.
https://c-frame.github.io/aframe-extras/examples/
MIT License
972 stars 307 forks source link

[gamepad-controls] Disable moving forwards when pressing trigger #392

Closed vincentfretin closed 1 year ago

vincentfretin commented 1 year ago

I discovered it while testing https://github.com/AdaRoseCannon/aframe-xr-boilerplate/pull/7 Since #373 was merged it seems, pressing trigger is moving forwards, is this intended or a bug? Can we disable this behavior?

vincentfretin commented 1 year ago

Oh the behavior that move forwards when pressing trigger comes from touch-controls since I merged #386 that take into account selectstart/selectend. I'm not sure how to fix it. Revert the changes from #386 or enable it behind an option for Chrome Android Cardboard? touch-controls="cardboardModeEnabled:true" (default false), similar to vr-mode-ui="cardboardModeEnabled:true"? Or maybe look if it's enabled on vr-mode-ui, then I enable the listener?