search

c-frame / aframe-extras

Add-ons and helpers for A-Frame VR.
https://c-frame.github.io/aframe-extras/examples/
MIT License
972 stars 305 forks source link

[Animation-mixer] crossFadeDuration not accepting values less than 1 #429

Closed CrowtreesStudio closed 1 year ago

CrowtreesStudio commented 1 year ago

I've been trying to blend walking to idle animations with a short easing out and into motion. It appears the only values that it accepts is 1 and 0 but not anything less than 1 (e.g. 0.5, 0.1, etc). Is this on purpose or a 'bug'?

vincentfretin commented 1 year ago

crossFadeDuration is used for the call to fadeIn https://github.com/c-frame/aframe-extras/blob/d85de74fa99aff7c8306d13091dff82f3a4dd328/src/loaders/animation-mixer.js#L128 The unit is seconds https://threejs.org/docs/index.html?q=animationac#api/en/animation/AnimationAction.fadeIn

Do you use aframe-extras 7.0.0? When I use 0.2 or 0.5 in https://c-frame.github.io/aframe-extras/examples/animation-controls/ that appears to work fine.

CrowtreesStudio commented 1 year ago

Oh nuts. So sorry Vincent, of course I wasn't using the current version, it works as advertised now. Argh. Carry on everyone...

Thanks Vincent

CrowtreesStudio commented 1 year ago

Resolved