c-frame / aframe-physics-system

community-maintained fork of n5ro's aframe-physics-system
https://c-frame.github.io/aframe-physics-system/
MIT License
43 stars 11 forks source link

Extend examples #11

Closed diarmidmackenzie closed 2 years ago

diarmidmackenzie commented 2 years ago

This PR covers:

Work on this PR has also uncovered a few issues that it has not resolved - these have been raised separately for future investigation. See issues #7, #8, #9, #10

If you want to see a live staged version of all the changes, ahead of this being merged, you can see that here: https://diarmidmackenzie.github.io/aframe-physics-system/

kylebakerio commented 2 years ago

throwing this link here, instead of just code comments, so that github hooks it in to that conversation for google and such: https://github.com/n5ro/aframe-physics-system/issues/171

kylebakerio commented 2 years ago

Love the examples, great work.

I get no reticle on the contraints for ammo page, the way I do on constraints for cannon. Are you aware of that and chose not to do it, or is it an error or oversight? Not a reason to deny the pull request, but nice to have if you were intending it.

kylebakerio commented 2 years ago

Would also be nice if the examples were separated under 'cannon' and 'ammo' categories.

I also feel like the 'attached to cone' in the initial examples for both is pretty awkward... just makes a bad first impression and looks broken. Not saying you should rework that (happy to have it if you are willing), but we should probably do that. Not sure what we should take away from that, but seems like just flipping the cone upside down and having cube on the flat side would be cleaner?

Am I alone in thinking this?

diarmidmackenzie commented 2 years ago

Would also be nice if the examples were separated under 'cannon' and 'ammo' categories.

Did you look at this page?

https://diarmidmackenzie.github.io/aframe-physics-system/examples/

I've realized that this page... https://diarmidmackenzie.github.io/aframe-physics-system/examples/

... has a link to the non-updated examples here: https://c-frame.github.io/aframe-physics-system/examples/

So maybe that caused some confusion?

diarmidmackenzie commented 2 years ago

I get no reticle on the contraints for ammo page

https://diarmidmackenzie.github.io/aframe-physics-system/examples/ammo/constraints.html

(see prev. comment, maybe you ended up one one of the non-updated pages due to incorrect absolute link)

diarmidmackenzie commented 2 years ago

I also feel like the 'attached to cone' in the initial examples for both is pretty awkward...

Yes, agreed. I'll try to do something to improve this.

diarmidmackenzie commented 2 years ago

I also feel like the 'attached to cone' in the initial examples for both is pretty awkward...

Yes, agreed. I'll try to do something to improve this.

Just moving the cone 1m to the left so the 2 objects are near to each other but don't intersect or z-fight makes this look a lot better IMO. I still don't love the example, but I'd rather work on new, better examples, than invest in this one any further...

kylebakerio commented 2 years ago

I'm sure the incorrect links were the issue.

Going to the ammo example now, I get a reticle, but I get broken examples.

image

...then, after pasting this image and being here, and flipping back to the tab in question, suddenly the example are now working.

image

Interesting. My internet is very slow here today, so that is probably the cause, figured I'll post anyways since it's interesting that that's possible.

kylebakerio commented 2 years ago

Is there anything left pending before this is ready for merge?

kylebakerio commented 2 years ago

image