search

c-frame / aframe-physics-system

community-maintained fork of n5ro's aframe-physics-system
https://c-frame.github.io/aframe-physics-system/
MIT License
43 stars 11 forks source link

Consider forking three-to-ammo into c-frame #59

Closed Elettrotecnica closed 7 months ago

Elettrotecnica commented 7 months ago

Dear all,

in order to correctly compute collision shapes for models using interleaved buffer attributes, I had to massage three-to-ammo a bit: https://github.com/InfiniteLee/three-to-ammo/pull/45

The PR is open since a while and I am not sure how active the original author is. Maybe three-to-ammo should be forked in c-frame?

All the best

vincentfretin commented 7 months ago

I invited you to c-frame organization, you can fork it, create the same PR there, probably tag @diarmidmackenzie for review and merge. Then change the dependency here in another PR. Thanks!

diarmidmackenzie commented 7 months ago

Hi, @Elettrotecnica, thanks for this.

I have published the 1.0.2 version of the package here: https://www.npmjs.com/package/@c-frame/three-to-ammo

Do you want to do a PR now to update aframe-physics-system to use that version of the package?

Elettrotecnica commented 7 months ago

Done! And thanks to you!