search

c-frame / aframe-stereo-component

aframe.io component to enable separate eye rendering of objects, plus stereo video rendering (full 360 or half dome)
https://c-frame.github.io/aframe-stereo-component/
MIT License
137 stars 52 forks source link

Error when using aframe 0.4.0 #14

Closed brenpolley closed 7 years ago

brenpolley commented 7 years ago

Uncaught (in promise) DOMException: Failed to execute 'querySelector' on 'Document': '[object HTMLVideoElement]' is not a valid selector.

Runs fine on 0.3.0

theDrGray commented 7 years ago

+1

dominicrico commented 7 years ago

+1

gwcmk commented 7 years ago

+1

Runnermax commented 7 years ago

+1

oscarmarinmiro commented 7 years ago

Guys, sorry for the inconvenience. I'll take a look and fix it this week. I'ven been buried in work for two months, apologies.

qdot commented 7 years ago

Hey! Needed 180 SBS video, decided to check this out. Looks like the material src attribute started returning an HTMLVideoElement in >= v0.4, instead of the selector it was using in < v0.4. Just removing the document.querySelector() call and just checking .src fixes this. I'll submit a pull request with this fix.

ngokevin commented 7 years ago

Thanks! Now just need to bump and publish.

ngokevin commented 7 years ago

If you're interested, I can help maintain, if you add me as GitHub collaborator and on npm (npm owner add ngokevin or npm owner add me@ngokevin.com).

oscarmarinmiro commented 7 years ago

Hey I'm sorry. I'm recovering from a cervical spine injury and could not have much 'computer time'.

I just bumped the version, published on npm, also a new release compatible with 0.5.0 is here: https://github.com/oscarmarinmiro/aframe-stereo-component/releases/tag/v0.5.0. I corrected a stupid bug (from me :) )affecting non-video objects too.

Kevin, thanks a lot for your offer. Now it's published here and in npm registry, but yes, also added you as an NPM owner and collaborator in Github (BTW in NPM 'ngokevin' worked but me@ngokevin.com did not.. probably me fault since I'm a complete mess in node-related). Attached a screenshot.

Thanks all for the patience and will be cool for me if you can just check the new release and tell me if it's ok! screen shot 2017-03-09 at 13 55 19

brenpolley commented 7 years ago

Many thanks! Wishing you a speedy recovery