c-frame / aframe-super-hands-component

👐All-in-one natural hand controller, pointer, and gaze interaction library for A-Frame
https://c-frame.github.io/aframe-super-hands-component/examples/
MIT License
357 stars 71 forks source link

Make Aframe 1.5.0 compatible (remove conflicts with new core component grabbable) #238

Open Plarixtu opened 10 months ago

Plarixtu commented 10 months ago

In Aframe 1.5.0 release there was a component added to core called "grabbable". This leads to conflicts with the component of super-hands, which has the same name.

arpu commented 10 months ago

maybe this should be changed in aframe?

vincentfretin commented 10 months ago

I don't think @dmarcos will want to change the name, the component is included in an aframe release already.

I didn't test, but you should be able to use the following to resolve the issue:

<script src="https://aframe.io/releases/1.5.0/aframe.min.js"></script>
<script>
delete AFRAME.components["grabbable"];
</script>
<script src="https://unpkg.com/super-hands@^3.0.3/dist/super-hands.min.js"></script>

We probably need to rename grabbable to sh-grabbable in this repo to really fix the issue.

jonarnaldo commented 9 months ago

any updates on this? 🙏

vincentfretin commented 9 months ago

@jonarnaldo Do the above code snippet works for you?

I'm not using this component, so I won't work it. But someone can make a PR if we agree on something here. If we rename the grabbable component, we probably want to rename all components hoverable, clickable, grabbable, stretchable, draggable, and droppable. What do you think @wmurphyrd?

Utopiah commented 8 months ago

I'd also recommend sh-grabbable because SupreHands depends on AFrame, not the other way around. What's the functionality difference though? Are they exactly equivalent or not?

PS: I'd also appreciate @wmurphyrd's view on the topic as he's been thinking on this quite a bit.

v5ma commented 7 months ago

jeezus, it took me forever to eventually get to this page, after trying everything to fix my code.

v5ma commented 7 months ago

[vincentfretin's solution works 100% I just tested it. It should be at least AT LEAST added to the Super Hands documentation including on the read me underneath Installation, UNTIL we have a new name to replace grabbable, like graspable

vincentfretin commented 7 months ago

PR welcome to add it to the README, thanks!

v5ma commented 6 months ago

It just occurred to me that someone could write a my-super-hands component also that somehow replaces the word grabbable with something else.

jgbarah commented 6 months ago

It seems the README is now updated, via #239.