search

c-he / NeMF

[NeurIPS 2022] Official implementation of "NeMF: Neural Motion Fields for Kinematic Animation"
MIT License
156 stars 9 forks source link

Bug with gt translation #4

Closed julianyulu closed 1 year ago

julianyulu commented 1 year ago

Hi,

Thanks for this awesome work and opensource.

A bug was found at : https://github.com/c-he/NeMF/blob/8daf6bac4d7d5e5ea185806fd46ceab683c63fe7/src/application.py#L289

where c2c(trans[i]) should be c2c(trans_gt[i]).

This bug will lead to foot sliding since the predicted translation could be different from the gt translation.

c-he commented 1 year ago

Thanks for pointing it out! The bug is fixed in the latest commit.