Fail when CORS proxy URL is required but missing

[gomorizsolt]

As is: if the option is omitted then getProxyURL() will produce:

undefined/https://medium.com/feed/c-hive

Expected:

• no undefined/ prefix / fallback option to another service
• output an error/warning to the console

As a minor improvement, let's also move getProxyURL() to its relevant context since it's not reused elsewhere.

[thisismydesign]

Let's raise an error if the proxy is not configured for services that need it.

[thisismydesign]

Is this still present?

[gomorizsolt]

AFAICT yes, it is.

[thisismydesign]

Giving a higher priority as it blocks open-sourcing - good point btw ;)

[thisismydesign]

Let's raise an error if the proxy is not configured for services that need it.

Just to point, if the proxy is not configured but there're no components that'd use it that's OK, no need to raise.

[gomorizsolt]

Let's raise an error if the proxy is not configured for services that need it.

Just to point, if the proxy is not configured but there're no components that'd use it that's OK, no need to raise.

Thanks. One question though: should this "crash" the whole page (i.e. throw new Error() without catching it somewhere) or let's just leave a message in place of the component where it's required? I'm of the opinion that this shouldn't affect the rendering of other components (see https://github.com/c-hive/dotdev/pull/112/files#r417883310).

[thisismydesign]

IMO it's ok if the page crashes in this case. Just make sure the error is visible in the console. But if you already created a smarter solution let's use that.

[gomorizsolt]

Resolved by #120.